Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: 🛠 Add artifact publishing to releases #22

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

berkus
Copy link
Contributor

@berkus berkus commented Nov 11, 2024

Adds a number of pipelines:

  • the original pipeline is left only for PR reviews - it still generates artifact files, which expire
  • a pre-release pipeline creates a pre-release from any commit to master
    • pre-releases are safe to ignore/delete, but files there will not expire
  • a release pipeline will trigger for any release created with tag starting with "v", like "v1.0" or "v77.88.99"
    • it will create an official release and set it as latest, keeping artifact files

Closes #14


For the pipeline being able to create a release, some changes in the repo settings need to be done:

image

The permissions tag in the pipeline configs will limit the scope of permissions to necessary level.


After this is merged, will need to fix whatever errors KiCad throws in the pipeline, then validate via pre-releases that appropriate set of files is collected, maybe repackage them a bit for more convenience - then once the file set is correct tag an official release.

Errors from the current KiCad pipeline, cc @Yatekii :

ERROR:Can't exit KiCad (pcbnew_do - interposer.py:654) (kibot - kiplot.py:130)
ERROR:Found 2 DRC errors and 9 unconnected pad/s or warnings (pcbnew_do - pcbnew_do:1443) (kibot - kiplot.py:130)
ERROR:(footprint_type_mismatch) Footprint component type doesn't match footprint pads (expected 'Through hole'; actual 'SMD'); Severity: error
    @(185.5000 mm, 86.0000 mm): Footprint J1 (pcbnew_do.kiauto.file_util - file_util.py:145) (kibot - kiplot.py:130)
ERROR:(footprint_type_mismatch) Footprint component type doesn't match footprint pads (expected 'Through hole'; actual 'SMD'); Severity: error
...
ERROR:DRC violations: 11 (kibot.gs - gs.py:850)

@berkus berkus force-pushed the add-pipeline-asset-releases branch from 358ea2e to c6d4f17 Compare November 12, 2024 17:43
Copy link
Collaborator

@korken89 korken89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

The error is OK, I can fix it. It seems new errors are reported now.
Lets fix that in a next PR.

@korken89 korken89 merged commit 2607792 into probe-rs:master Nov 13, 2024
1 check failed
@berkus berkus deleted the add-pipeline-asset-releases branch November 14, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Board file artifacts expire
2 participants