-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor handling of logging and user messaging. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noppej
changed the title
WIP: Refactor handling of logging and user messaging.
Refactor handling of logging and user messaging.
Dec 16, 2022
Yatekii
reviewed
Dec 27, 2022
Yatekii
reviewed
Dec 27, 2022
Yatekii
reviewed
Dec 27, 2022
Yatekii
reviewed
Dec 27, 2022
Yatekii
reviewed
Dec 27, 2022
Yatekii
reviewed
Dec 27, 2022
Yatekii
reviewed
Dec 27, 2022
I added a few nits that are not a must but would be nice :) |
Co-authored-by: Noah Hüsser <Yatekii@users.noreply.github.com>
Co-authored-by: Noah Hüsser <Yatekii@users.noreply.github.com>
Co-authored-by: Noah Hüsser <Yatekii@users.noreply.github.com>
Much appreciated ... nits or not, they help improve code quality, and worth the few minutes it takes to address. Thanks ! |
bors bot
added a commit
to probe-rs/probe-rs
that referenced
this pull request
Dec 30, 2022
1334: Refactor handling of logging and user messaging in `probe-rs-debugger` r=Yatekii a=noppej Please see (and synchronize merge with): [VSCode PR#37](probe-rs/vscode#37) Co-authored-by: JackN <noppej@hotmail.com>
Yatekii
approved these changes
Dec 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bors r+
Build succeeded:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
probe-rs
recently adopted thetracing
crate for logging. This opened up the possibility to cleanup how logging was implemented in the VSCode extension and associatedprobe-rs-debugger
.This PR will do the following:
launch.json
setting to directprobe-rs
logging to a JSON file, which can later be analyzed with the log viewer.probe-rs
(RUST_LOG) logging from the data being reported in the VSCode debug console. It is currently interspersed with debug adapter logging, and although somewhat informative, it makes it less than useful when analyzingprobe-rs
specific issues.probe-rs-debugger
handling of MS DAP events and messages, to be more useful (objective opinion) to users of the extension.probe-rs-debugger
logging will happen according to these rules:LevelFilter
to configure a subscriber that logs to a file in the system's application data directory.LevelFilter::ERROR
to stderr (because these errors are picked up and reported to the user by the VSCode extension).NOTE This release requires changes to the
launch.json
files in user projectsconsoleLog
property only supports one of three values[Console, Info, Debug]
env
properties, for example:For testing, feel free to use the extension binary