Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tcp-socket image too wide on cargo-embed docs #147

Merged
merged 2 commits into from
Aug 21, 2024

Conversation

joelsa
Copy link
Contributor

@joelsa joelsa commented Aug 7, 2024

On the cargo-embed website, the tcp-socket image is far too wide on my screen:

image

@joelsa joelsa changed the title Fix image too wide Fix tcp-socket image too wide on cargo-embed docs Aug 7, 2024
@probe-rs-bot
Copy link

Preview

@joelsa
Copy link
Contributor Author

joelsa commented Aug 7, 2024

Looks good in preview:

image

@bugadani
Copy link
Contributor

Maybe this works for you, but not for me :)

@probe-rs-bot
Copy link

Preview

@joelsa
Copy link
Contributor Author

joelsa commented Aug 21, 2024

Maybe this works for you, but not for me :)

You are right, I only checked on Safari and Chromium, not on a real Browser that uses Rust under the hood. ;)
Inline HTML didn't work in Firefox, so I changed it to to Jekyll attribute lists, which now works on all my Firefoxes, Chromiums, Safaris and on all my OSes.

Can you check again?

@bugadani
Copy link
Contributor

Awesome, thanks! :)

@bugadani bugadani enabled auto-merge August 21, 2024 15:30
@bugadani bugadani merged commit 6c4547a into probe-rs:master Aug 21, 2024
2 checks passed
@joelsa joelsa deleted the patch-1 branch August 21, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants