Use reverse=True keyword argument in lax.scan for smoothers #365
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #364 by using the
reverse=True
keyword argument inlax.scan
function.Tests are passing locally except for the unscented kalman filter inference tests, but these were also failing for the original code as far as I can tell?
I also had to pin
numpy < 2.0
becausetensorflow_probability
was failing (note that this is also a problem in the docs.There could potentially be further improvement in eliminating unnecessary memory copies by array slicing but I think it would destroy some of the readability of the code and result in some computation overhead. For example, the stack operations (
jnp.vstack([smoothed_probs, filtered_probs[-1]])
and slicingfiltered_probs[:-1]
) create copies. This isn't really a problem unless you have a large number of states: