Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply PR #4 without Synth_Dexed git submodule #5

Merged
merged 2 commits into from
Feb 15, 2022
Merged

Apply PR #4 without Synth_Dexed git submodule #5

merged 2 commits into from
Feb 15, 2022

Conversation

probonopd
Copy link
Owner

Credits: @dcoredump

PR #4 refers to Synth_Dexed c6e768820cffd2c9db277ebce3faf67b27efb26b which does not seem to exist. Hence applying the changes this way.

Credits: @dcoredump

PR #4 refers to  [Synth_Dexed](https://codeberg.org/dcoredump/Synth_Dexed) `c6e768820cffd2c9db277ebce3faf67b27efb26b` which [does not seem to exist](https://github.com/probonopd/MiniDexed/runs/5204665368?check_suite_focus=true#step:3:11). Hence applying the changes this way.
@probonopd probonopd mentioned this pull request Feb 15, 2022
@probonopd
Copy link
Owner Author

CPP   main.o
  CPP   kernel.o
  CPP   ../Synth_Dexed/src/synth_dexed.o
../Synth_Dexed/src/synth_dexed.cpp: In static member function 'static void AudioSynthDexed::KeyStatusHandlerRaw(unsigned char, const unsigned char*)':
../Synth_Dexed/src/synth_dexed.cpp:1993:17: error: 'ucKeyNumber' was not declared in this scope; did you mean 'm_ucKeyNumber'?
 1993 |  s_pThis->keyup(ucKeyNumber);
      |                 ^~~~~~~~~~~
      |                 m_ucKeyNumber
make: *** [../circle-stdlib/libs/circle/Rules.mk:[14](https://github.com/probonopd/MiniDexed/runs/5205110565?check_suite_focus=true#step:6:14)3: ../Synth_Dexed/src/synth_dexed.o] Error 1
make: *** Waiting for unfinished jobs....

@probonopd probonopd merged commit 46ef06c into main Feb 15, 2022
@probonopd probonopd deleted the pull-4 branch February 15, 2022 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant