Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hopefully a fix for "Modulation Range Error #562" #565

Draft
wants to merge 22 commits into
base: main
Choose a base branch
from
+9 −9
Draft

Hopefully a fix for "Modulation Range Error #562" #565

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
0be1d99
Fix for using the right MIDI channel for SYSEX.
May 17, 2022
8a143af
Small fixes for recognizing MIDI channel in SYSEX.
May 17, 2022
7e4e650
Reenabled showing incomfing MIDI data when MIDI-DUmp is enabled.
May 20, 2022
2cb0631
Several fixes for SYSEX handling.
dcoredump May 21, 2022
55e90c6
Code for sending a voice dump via MIDI started.
dcoredump May 21, 2022
0b75186
Fix for sending SYSEX voice dump to all interfaces.
May 22, 2022
7666793
Sending voice data via SYSEX when voice is changed.
May 22, 2022
01f9903
Forgot to initialize nMasterVolume - just added it.
May 22, 2022
c30a9c0
Merge.
May 22, 2022
6c5da6c
Merge branch 'main' of https://github.com/probonopd/MiniDexed into pr…
May 22, 2022
ce56c9d
Merge branch 'probonopd-main'
May 22, 2022
7afc844
Added a SpinLock around MIDI message processing.
May 24, 2022
8213904
Added notesOff() when changing algorithm parameter (can be extended l…
May 24, 2022
db25111
Merge branch 'probonopd:main' into main
dcoredump May 25, 2022
57a4483
Merge branch 'probonopd:main' into main
dcoredump May 30, 2022
04afcee
Fix for garbage when showing device name.
May 31, 2022
9e59e16
Merge branch 'probonopd:main' into main
dcoredump Jun 7, 2022
92f626d
Merge remote-tracking branch 'upstream/main'
Jul 17, 2022
6cf87bd
Merge branch 'probonopd:main' into main
dcoredump Nov 20, 2023
d81b242
Comments on some "m_pTG[nTG]->ControllersRefresh();" when changing th…
Nov 20, 2023
e05cb6c
Synth_Dexed af3c7ce
probonopd Nov 20, 2023
7a2a501
Merge branch 'main' into main
probonopd Jul 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions src/minidexed.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1490,7 +1490,7 @@ void CMiniDexed::setModWheelRange(uint8_t range, uint8_t nTG)
m_pTG[nTG]->setMWController(range, m_pTG[nTG]->getModWheelTarget(), 0);
// m_pTG[nTG]->setModWheelRange(constrain(range, 0, 99)); replaces with the above due to wrong constrain on dexed_synth module.

m_pTG[nTG]->ControllersRefresh();
//m_pTG[nTG]->ControllersRefresh();
m_UI.ParameterChanged ();
}

Expand All @@ -1502,7 +1502,7 @@ void CMiniDexed::setModWheelTarget(uint8_t target, uint8_t nTG)
m_nModulationWheelTarget[nTG] = target;

m_pTG[nTG]->setModWheelTarget(constrain(target, 0, 7));
m_pTG[nTG]->ControllersRefresh();
//m_pTG[nTG]->ControllersRefresh();
m_UI.ParameterChanged ();
}

Expand All @@ -1515,7 +1515,7 @@ void CMiniDexed::setFootControllerRange(uint8_t range, uint8_t nTG)
m_pTG[nTG]->setFCController(range, m_pTG[nTG]->getFootControllerTarget(), 0);
// m_pTG[nTG]->setFootControllerRange(constrain(range, 0, 99)); replaces with the above due to wrong constrain on dexed_synth module.

m_pTG[nTG]->ControllersRefresh();
//m_pTG[nTG]->ControllersRefresh();
m_UI.ParameterChanged ();
}

Expand All @@ -1527,7 +1527,7 @@ void CMiniDexed::setFootControllerTarget(uint8_t target, uint8_t nTG)
m_nFootControlTarget[nTG] = target;

m_pTG[nTG]->setFootControllerTarget(constrain(target, 0, 7));
m_pTG[nTG]->ControllersRefresh();
//m_pTG[nTG]->ControllersRefresh();
m_UI.ParameterChanged ();
}

Expand All @@ -1540,7 +1540,7 @@ void CMiniDexed::setBreathControllerRange(uint8_t range, uint8_t nTG)
m_pTG[nTG]->setBCController(range, m_pTG[nTG]->getBreathControllerTarget(), 0);
//m_pTG[nTG]->setBreathControllerRange(constrain(range, 0, 99));

m_pTG[nTG]->ControllersRefresh();
//m_pTG[nTG]->ControllersRefresh();
m_UI.ParameterChanged ();
}

Expand All @@ -1552,7 +1552,7 @@ void CMiniDexed::setBreathControllerTarget(uint8_t target, uint8_t nTG)
m_nBreathControlTarget[nTG]=target;

m_pTG[nTG]->setBreathControllerTarget(constrain(target, 0, 7));
m_pTG[nTG]->ControllersRefresh();
//m_pTG[nTG]->ControllersRefresh();
m_UI.ParameterChanged ();
}

Expand All @@ -1565,7 +1565,7 @@ void CMiniDexed::setAftertouchRange(uint8_t range, uint8_t nTG)
m_pTG[nTG]->setATController(range, m_pTG[nTG]->getAftertouchTarget(), 0);
// m_pTG[nTG]->setAftertouchRange(constrain(range, 0, 99));

m_pTG[nTG]->ControllersRefresh();
//m_pTG[nTG]->ControllersRefresh();
m_UI.ParameterChanged ();
}

Expand All @@ -1577,7 +1577,7 @@ void CMiniDexed::setAftertouchTarget(uint8_t target, uint8_t nTG)
m_nAftertouchTarget[nTG]=target;

m_pTG[nTG]->setAftertouchTarget(constrain(target, 0, 7));
m_pTG[nTG]->ControllersRefresh();
//m_pTG[nTG]->ControllersRefresh();
m_UI.ParameterChanged ();
}

Expand Down
2 changes: 1 addition & 1 deletion submod.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,5 +20,5 @@ cd -
#
# Use fixed master branch of Synth_Dexed
cd Synth_Dexed/
git checkout c9f5274
git checkout af3c7ce
cd -
Loading