Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fx full by @jnonis #795

Draft
wants to merge 15 commits into
base: fx-full
Choose a base branch
from
Draft

Fx full by @jnonis #795

wants to merge 15 commits into from

Conversation

probonopd
Copy link
Owner

No description provided.

jnonis added 13 commits December 26, 2024 19:52
@jnonis
Squashed commit of the following:
0a25ede 
commit a2a4f18
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Thu Aug 8 20:32:38 2024 -0300

    Fix for Midi Clock Sync

commit 20eeb54
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Sat Aug 3 23:06:17 2024 -0300

    Added Flanger

commit 7f21a03
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Sat Aug 3 15:16:42 2024 -0300

    UI improvements

commit 8538869
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Sat Aug 3 00:24:45 2024 -0300

    Fix for FX UI

commit 035b310
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Fri Aug 2 20:39:44 2024 -0300

    Fix for RPi 1 Stereo output

commit bd31b24
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Tue Jul 30 22:42:36 2024 -0300

    Fix for MVerb port

commit f7d3baf
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Tue Jul 30 18:27:39 2024 -0300

    Fix for Reverb backward compatibility

commit d695762
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Sun Jul 28 18:46:59 2024 -0300

    Fix for A Phaser parameters

commit 38f9f5f
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Sat Jul 27 16:16:49 2024 -0300

    AudioEffect refactor

commit 17f6fc9
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Fri Jul 26 20:47:27 2024 -0300

    Fix missing Send FX setup for Phasers

commit aae85e5
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Wed Jul 24 18:11:43 2024 -0300

    Added RKR / Zynaddsubfx Phasers

commit f0e2593
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Tue Jul 23 13:12:29 2024 -0300

    Fix for MVerb

commit 2d19311
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Mon Jul 22 19:59:15 2024 -0300

    Refactor Effect directory

commit 37c152d
Merge: 9c55aa6 d6fbbb5
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Mon Jul 22 18:59:55 2024 -0300

    Merge pull request #1 from jnonis/arp

    Merge Arp branch to FX branch

commit d6fbbb5
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Mon Jul 22 18:18:08 2024 -0300

    Added 3 Band EQ

commit 6d673aa
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Mon Jul 22 16:46:33 2024 -0300

    Added MVerb effect

commit bf30d1a
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Sat Jul 20 20:15:13 2024 -0300

    UI fix for Tempo display

commit d7336ee
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Sat Jul 20 20:14:08 2024 -0300

    Save Tempo into Performance

commit 652db3e
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Sat Jul 20 17:49:53 2024 -0300

    Store Midi FX settings into performance

commit 6cd3a82
Author: Javier Nonis <javiernonis@gmail.com>
Date:   Sat Jul 20 16:21:47 2024 -0300

    Handle Arp as a Midi FX

commit 8f59754
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Fri Jul 19 16:41:09 2024 +0000

    Arp fixes

commit 61f6684
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Fri Jul 19 04:56:58 2024 +0000

    Added Arp to TG menu

commit b2dcc29
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Thu Jul 18 04:34:13 2024 +0000

    Removed log from Arp

commit d4f99f8
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Thu Jul 18 04:31:42 2024 +0000

    Almost working Arp

commit 0cb0553
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Thu Jul 18 04:15:19 2024 +0000

    Not working Arp

commit 9c55aa6
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Sun Jul 14 22:19:46 2024 +0000

    Delay FX: Support for tempo sync

commit bed555f
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Sun Jul 14 16:11:36 2024 +0000

    Fix for FX Params

commit 0a68eb5
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Wed Jul 10 04:24:55 2024 +0000

    Handle Midi clock and resolve BPM

commit cd785aa
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Tue Jul 9 23:01:24 2024 +0000

    Added Backward compatibility for performances

commit fc6f715
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Tue Jul 9 04:47:42 2024 +0000

    Adapted Plate Reverb as AudioEffect

commit 751b69d
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Mon Jul 8 22:35:56 2024 +0000

    Save Send FX configuration in performance

commit 7c2638c
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Sun Jul 7 04:56:43 2024 +0000

    WIP: Added Send FX

commit 17105a9
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Sat Jul 6 22:00:33 2024 +0000

    Code clean up

commit 5091555
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Sat Jul 6 21:37:29 2024 +0000

    Fixes for Tal Reverb 3 paramteres

commit 002c2b9
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Sat Jul 6 21:07:16 2024 +0000

    Added Ping Pong Mode and Mix control to Delay FX

commit 897c35a
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Fri Jul 5 06:00:33 2024 +0000

    Insert FX UI improvements

commit 881149e
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Wed Jul 3 04:36:32 2024 +0000

    Process TG in stereo

commit e034e66
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Fri Jun 28 00:24:57 2024 +0000

    Added Tal Reverb 3

commit 116881b
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Thu Jun 27 04:02:08 2024 +0000

    Fix for distortions

commit 6f05c23
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Thu Jun 27 03:48:02 2024 +0000

    Added Mod Distortions DS1 and BigMuff

commit 2d85439
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Wed Jun 26 22:52:30 2024 +0000

    Fix for Bypass and Removed Logs

commit 172c651
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Wed Jun 26 04:40:15 2024 +0000

    Added Bypass to FX Parameters

commit 8ca2177
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Wed Jun 26 04:12:58 2024 +0000

    Fix for Insert FX paramters ui

commit 7c8dc6f
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Wed Jun 26 03:45:03 2024 +0000

    Save Insert FX parameters into performance

commit 7f110b2
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Mon Jun 24 02:40:47 2024 +0000

    Added generic fx paramters handling

commit 9b1ea33
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Sun Jun 23 18:53:29 2024 +0000

    Added LP Filter Effect

commit 75f4333
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Sun Jun 23 08:11:36 2024 +0000

    Added delay implementation

commit 7bcba91
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Sun Jun 23 02:06:54 2024 +0000

    Added lock to inser FXs to avoid crashes.
    Code clean up.

commit d98c7cf
Author: jnonis <jnonis@users.noreply.github.com>
Date:   Sat Jun 22 04:43:23 2024 +0000

    Added Insert FX and Juno Chorus
@jnonis
Updated FX branch for lastest changes
47de8fb
@jnonis
Added "As Played" velocity to Midi Arp
c9fa7b5
@jnonis
Reduce Mverb FX memory usage to avoid issues
ec83753
@jnonis
Added configuration for buttons debounce time
cc5acfb
@jnonis
FX Code clean up
427b30b
@jnonis
Recovered missing changes for FXs with Single Core RPis
7f85e1f
@jnonis
Fix for RPI 1 support
2a3b2ee
@jnonis
Added Master FX
7ac0b9d
@jnonis
Added Send FX 2
be718fc
@jnonis
LCD Update performance fix to avoid glitches on single core RPis
4d2d79c
@jnonis
Avoid glitches and noise when distortion fx are loaded
4632800
@jnonis
Added Send FX 1 to performance load and save
569b866
@github-actions GitHub Actions
Copy link

Build for testing:
MiniDexed_2025-01-12-6e89ab4
Use at your own risk.

@probonopd probonopd marked this pull request as draft January 12, 2025 17:20
@probonopd probonopd mentioned this pull request Jan 12, 2025
Closed
@probonopd
Copy link
Owner Author

probonopd commented Jan 12, 2025 •
edited
Loading

Working well so far on my Raspberry Pi Zero 2 W. 000118_TX816 EP FX.zip plays well for me with no crackle.

Here we have

  • For each TG: 1 MIDI FX and 1 Insert FX
  • Globally: 2 Send FX and 1 Master FX

@github-actions GitHub Actions
Copy link

Build for testing:
MiniDexed_2025-01-12-7175505
Use at your own risk.

@Banana71
Copy link

Build for testing:
MiniDexed_2025-01-12-7175505

Testet with my Raspberry Pi 3 Model A+

  • If I set the sample rate to 22000Hz the sound output works reliably.
  • The SSD1306 display seems slower, the display is no longer built up as quickly
  • The "Save as default" command does not work correctly. The first performance of the current bank is overwritten. (Probably a bug that applies to all versions)
  • The sample rate set in the minidexed.ini affects the reverb time of the standard Reverb effect. Higher sample rates mean shorter reverb times and correspondingly lower sample rates mean longer reverb times.
  • The DAC crashes during many performances. When loading a performance, there is a loud cracking sound and the audio output can only be revived by restarting. I have not yet found a common cause for this.

@probonopd
Copy link
Owner Author

Thanks for your testing @Banana71, this is really a big help.

If I set the sample rate to 22000Hz the sound output works reliably.

So far I have not tested other sample rates. Do you know sample rates that work with the normal build but not with this one?

The SSD1306 display seems slower, the display is no longer built up as quickly

I noted the same with a 16x2 character display. I wonder what additional processing is going on even when no sound is playing?

The "Save as default" command does not work correctly. The first performance of the current bank is overwritten. (Probably a bug that applies to all versions)

Can you please retest this with the normal version and open a bug if it is there too?

The sample rate set in the minidexed.ini affects the reverb time of the standard Reverb effect. Higher sample rates mean shorter reverb times and correspondingly lower sample rates mean longer reverb times.

Is this only the case for the (old) standard Reverb effect or also for the new ones? (Should we even keep the old one once we have the new ones?)

The DAC crashes during many performances. When loading a performance, there is a loud cracking sound and the audio output can only be revived by restarting. I have not yet found a common cause for this.

Can you please give a few examples so that we can replicate?

@probonopd
Copy link
Owner Author

probonopd commented Jan 12, 2025 •
edited
Loading

Noticed the following:

When I switch on MiniDexed, play a bit, and then just let it sit for a while (e.g., half an hour to an hour) and then try to play again, it stays silent. On Raspberry Pi Zero 2 W with Keystation Mini32 MK3. (Not sure whether this is a hardware issue and/or whether it also happens with the normal MiniDexed version. Just something to watch out for.)

@Banana71
Copy link

So far I have not tested other sample rates. Do you know sample rates that work with the normal build but not with this one?

A sample rate of 48000 and the use of effects on all TGs causes crackling in the sound output. I haven't tested other sample rates up to 22000. I haven't tried fewer TGs either.

The "Save as default" command does not work correctly. The first performance of the current bank is overwritten. (Probably a bug that applies to all versions)
Can you please retest this with the normal version and open a bug if it is there too?

The main version is also affected.

I only noticed the dependence of the reverb time on the sample rate with the old standard reverb.

e.g. the DAC crashes with the following performances: 001:041 Barock, 001:065 1984, 002:001 mDx-Strg.AT (which is why I can't test the Greenhouse bank)

The feedback parameter for the delay effect is incorrect. If the feedback value is set to zero, the delay should work like an echo. Unfortunately, there is then no echo at all. I hope you understand what I mean

@probonopd
Copy link
Owner Author

I only noticed the dependence of the reverb time on the sample rate with the old standard reverb.

Ah right, that's a known issue of the old reverb, so unrelated to this change.

@Banana71
Copy link

The effects chain has been changed more often now and I think it has gotten better and better. But as I would like it to be.

In each TG the following: Send FX 1, Send FX 2, EQ
under Effects: FX1, FX2, Compressor, The parameters of the compressor should be changeable (threshold, ratio, input, output, gain or whatever the compressor can do). The compressor should always be at the last position in the chain.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@probonopd @Banana71 @jnonis