Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #192 #193

Merged
merged 1 commit into from
Apr 2, 2022
Merged

Fix #192 #193

merged 1 commit into from
Apr 2, 2022

Conversation

CalebQ42
Copy link
Contributor

@CalebQ42 CalebQ42 commented Apr 1, 2022

Fixes #192 by adding arguments that are present in the AppImage's desktop file to the generated desktop file. Also a partial fix for #183.

@CalebQ42
Copy link
Contributor Author

CalebQ42 commented Apr 1, 2022

Actually, should only field codes (such as %U) be included since other arguments should already be passed to the AppImage's AppRun by the AppImage itself? But then in #183 it's mentioned that --no-sandbox is needed in both places, which seems a bit odd.

@probonopd
Copy link
Owner

probonopd commented Apr 2, 2022

Thanks @CalebQ42.

But then in #183 it's mentioned that --no-sandbox is needed in both places, which seems a bit odd.

I think I can explain this, if memory serves me right:

So far, we have been disregarding arguments in desktop files in most places within the AppImage ecosystem. Instead, so far we have only used the first argument from the Exec= line and have appended any arguments given on the comand line to the AppImage. If I remember correctly.

@probonopd probonopd merged commit c2f9a98 into probonopd:master Apr 2, 2022
@CalebQ42 CalebQ42 mentioned this pull request Apr 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

appimaged desktop files: Arguments are not passed correctly
2 participants