Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
csouchet authored Sep 6, 2023
1 parent a145aaf commit 68b84ff
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 5 deletions.
2 changes: 1 addition & 1 deletion rollup.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import commonjs from '@rollup/plugin-commonjs'; // at least, needed to bundle mx
import resolve from '@rollup/plugin-node-resolve';
import terser from '@rollup/plugin-terser';
import cleanup from 'rollup-plugin-cleanup';
// eslint-disable-next-line import/no-unresolved
// eslint-disable-next-line import/no-unresolved -- The package is malformed. So, the rule doesn't resolve it.
import externals from 'rollup-plugin-node-externals';
import sizes from 'rollup-plugin-sizes';
import typescript from 'rollup-plugin-typescript2';
Expand Down
3 changes: 0 additions & 3 deletions scripts/generate-types-for-not-supported-ts-versions.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ limitations under the License.

import * as fs from 'node:fs';

// generate warning when running with Node 18
// (node:75278) ExperimentalWarning: Importing JSON modules is an experimental feature. This feature could change at any time
import packageJSON from '../package.json' assert { type: 'json' };

import { getTypeFilesInformation } from './shared/types-info.mjs';

Expand Down
2 changes: 1 addition & 1 deletion test/typescript-support/src/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ See the License for the specific language governing permissions and
limitations under the License.
*/

// eslint-disable-next-line import/no-unresolved
// eslint-disable-next-line import/no-unresolved -- The bpmn-visualization package may not have been built prior running eslint (it happens when running GitHub Actions)
import { BpmnVisualization } from 'bpmn-visualization';

const bpmnVisualization = new BpmnVisualization({ container: 'bpmn-container' });
Expand Down

0 comments on commit 68b84ff

Please sign in to comment.