Failed to upload files with non-English names

[oneandzeros]

Nature of issue?

• Found a bug

Details about the bug:

• Web browser and version: chrome 85.0.4183.121
• Operating System: windows 10 pro
• Steps to reproduce this bug:

I was trying to upload a png file with name "图片.png" , the uploading process is OK, but picture does not show in the Sketch files list .

I rename it with "tmp.png", reprocess the uploading and it worked.

This is how I did it：

Another thing is that I tested a file with name "思维导图笔记.html" , and it worked!

I think only some of the none-Engish names would fail, not all.

Please check.

[welcome]

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

[catarak]

Thanks for reporting! I would like for the web editor to support non-English file names, and thanks for submitting some examples of filenames that work and don't work.

[oneandzeros]

Thanks for reporting! I would like for the web editor to support non-English file names, and thanks for submitting some examples of filenames that work and don't work.

works:
图片.html
思维导图笔记.html
878世界.html

not work:
图片.png
文本21.gif
878世界.gif
新球大战.gif
这里是地球.gif
코딩을.png

I think all the html files works. Only pictures have this problem?

[catarak]

That's super helpful! The way that text files versus images/videos/fonts/etc. are uploaded is different. Text files are uploaded directly to the web editor, whereas other files are uploaded to an Amazon S3 bucket.

[adarzh-sys]

Hey! First timer here, I would love to help with this issue, any help on how exactly I should proceed would be really helpful :)

[catarak]

Hi @adarsh-qclw! The first step is getting the web editor running locally on your computer. Then, once that is working, the component that handles the file uploading is FileUploader.jsx, and from that component can see all of the functions/API requests that are being made to upload a file, and hopefully figure out what's going wrong.

[adarzh-sys]

Thanks @catarak ! Is this probably an issue due to encoding not being UTF-8 ?

[catarak]

@adarsh-qclw I think that is a great guess 😄 I would suggest testing and confirming that!

[adarzh-sys]

Hey, I'm afraid I'm stuck here. How do I test out my change? Because, in order to try uploading, I need to sign in, which I am unable to, in my local environment. Help? I am a total beginner, please pardon my frequent doubts :")

[catarak]

In local development, you're using a database that doesn't have your login information that you have on the production web editor, and you'll need to create a new account. This account is only for local testing and none of your sketches will be public.

[ricknjacky]

@catarak can I work on this issue? as there have been no recent follow ups