what errors / warnings to suppress?

[shiffman]

This came up today, whether we want the editor to highlight errors like missing semi-colons. For example the following has a 'missing semi-colon' error which is correct in one sense, but not always the convention in p5 examples.

var blah = function() {
  console.log('blah');
}

[catarak]

To do this linting I'm using JSHint/CSSLint/HTMLHint, so we can just add custom configuration to whatever we think is reasonable.

[catarak]

Just removed the error for missing semicolons... let me know if there are any other errors that should be removed, or errors that should be added. For reference, here's the JSHint options.

[lmccart]

I think it would be useful to suppress the == warning.

[catarak]

I like that warning since my personal JS style is to never use == and !=, but I could be convinced that it's a confusing warning for beginner coders.

[lmccart]

Hah I also like the warning for myself! But most of our examples and teaching materials use ==, because teaching the distinction early on feels really confusing. I'm not sure what the answer is.. @shiffman thoughts?

[shiffman]

I would err on the side of suppressing the warning for the web editor since I am so lackadaisical about the distinction, but it wouldn't take much to convince me otherwise. Are there scenarios where code won't work properly and having the warning could help?

[catarak]

I think the biggest issue is that it can lead to unexpected behavior when comparing different data types, e.g.

console.log(3 == "3"); // true
console.log(3 === "3"); // false.

however, I imagine stuff like this isn't in any of the p5 examples or lessons, so I think it's okay to leave this warning off.