-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improper setup of obsolete package react-hot-loader
#2134
Labels
Comments
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working on other features I have encountered a bunch of errors, warnings, and problems relating to the
react-hot-loader
package. This is a hindrance to the future development of this project and provides unnecessary obstacles to development.Package is obsolete
The best way to fix all of these issues is to not use this package. The package itself recommends that you don't use it anymore:
Doesn't work most of the time
I usually see the "hot update was not successful" message and need to manually refresh the page.
Improper setup
I have seen an error related to using
hot(App)
andReactDOM.render()
in the same file. We are definitely doing that!p5.js-web-editor/client/index.jsx
Lines 31 to 33 in 9073487
Missing peer dependency
Here's the discussion on that issue
Can create other problems
Here's an issue that I encountered while working on the
react-router
code. Thereact-hot-loader
package converts all components to a proxied version which breaks the router (discussion). I am able to work around this by writing the router code differently, but it's annoying.The text was updated successfully, but these errors were encountered: