Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Logout Confirmation Modal #2492

Closed
skbhagat0502 opened this issue Oct 5, 2023 · 9 comments
Closed

Feature Request: Logout Confirmation Modal #2492

skbhagat0502 opened this issue Oct 5, 2023 · 9 comments

Comments

@skbhagat0502
Copy link

Increasing Access

Benefits:

  1. User-Friendly: Reduces the likelihood of accidental logouts.
  2. Enhanced Security: Provides an additional layer of confirmation for sensitive actions.
  3. Consistency: Aligns with modern web practices for user interactions.

Feature request details

Description:
Currently, the website includes a logout button to allow users to sign out. To enhance the user experience and prevent accidental logouts, I propose the implementation of a logout confirmation modal.

Details:
Upon clicking the logout button, a modal should appear, asking the user to confirm their intention to log out. The modal should include a clear message such as "Are you sure you want to log out?" along with buttons for "Confirm" and "Cancel."

@skbhagat0502
Copy link
Author

@lindapaiste Can I work on this?

@perminder-17
Copy link
Contributor

Good feature request @skbhagat0502

@aspired2001
Copy link

I would like to work on this please assign me this project

@lindapaiste
Copy link
Collaborator

@lindapaiste Can I work on this?

I am not the one in charge so idk if @raclim has any thoughts about this. But it sounds fine to me if you want to put in a PR @skbhagat0502.

@skbhagat0502
Copy link
Author

@lindapaiste @raclim I am working on this.

@skbhagat0502
Copy link
Author

@raclim @lindapaiste please review this.

@abhinav700
Copy link

abhinav700 commented Jan 1, 2024

@raclim @skbhagat0502 I would like to work on this issue. Is it still open?

@PiyushThapaa
Copy link
Contributor

@raclim @lindapaiste Instead of making logout confirmation modal we can simply use confirm function for confirmation as it reduces code size. Also the confirmation of deletion of a sketch of user uses confirm function so we should go with it. If this is a good idea can I start working on this issue...?

PiyushThapaa added a commit to PiyushThapaa/p5.js-web-editor that referenced this issue Feb 18, 2024
@raclim
Copy link
Collaborator

raclim commented Apr 23, 2024

Thanks for raising this request! After giving this some thought, I don't think adding a confirmation modal on logout is necessary as it isn't a common design pattern. I'm going to close this issue and its associated PRs, but please feel free to check out other issues!

@raclim raclim closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
7 participants