Clicking on Collection by username redirects to blank page

[PiyushChandra17]

p5.js version

2.9.2

What is your operating system?

Mac OS

Web browser and version

Chrome and 117.0.5938.132

Actual Behavior

Clicking on Collection by username redirects to blank page with a horizontal line on top

redirection.mov

Expected Behavior

It should redirect logged in user to their own created sketches page

Steps to reproduce

Steps:

1. Open the editor web app
2. Click on hello! username
3. Click on my collections
4. Click on collection name in table
5. Click on collection by username
6. Verify it redirects to blank page

[mhsh312]

The error is in the following code:

p5.js-web-editor/client/modules/User/components/Collection.jsx

Lines 299 to 303 in c448094

	<p className="collection-metadata__user">
	{this.props.t('Collection.By')}
	<Link to={`${hostname}/${username}/sketches`}>
	{owner.username}
	</Link>

The <Link> here takes the user to http://<hostname>/<username>/collections/http://<hostname>/<username>/sketches while it should take them to http://<hostname>/<username>/sketches.

Changing the Link to the following fixes the issue:
<Link to="/sketches">{owner.username}</Link>

Before:

After:

Please assign this issue to me so I can make a PR.

[lindapaiste]

@mhsh312 You are exactly right about the problem and the solution.

@raclim I fixed this months ago in #2253, though it seems I didn't mention it in the PR notes. Can we get this merged? It's really frustrating to see people reporting errors that should have been fixed a long time ago.

p5.js-web-editor/client/modules/User/components/CollectionMetadata.jsx

Lines 86 to 89 in 1bca271

	<p className="collection-metadata__user">
	{t('Collection.By')}
	<Link to={`/${username}/sketches`}>{username}</Link>
	</p>

[raclim]

@lindapaiste yeah we can probably get that PR in for this Monday's PATCH release, sorry about that! Feel free to go ahead with adding any other PRs that you'd want to see out soon to the milestones as well.