-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Move CollectionMetadata
into its own component.
#2253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
raclim
merged 8 commits into
processing:develop
from
lindapaiste:refactor/collection-details
Nov 17, 2023
Merged
Move CollectionMetadata
into its own component.
#2253
raclim
merged 8 commits into
processing:develop
from
lindapaiste:refactor/collection-details
Nov 17, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
…o refactor/collection-details
4 tasks
PiyushChandra17
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely Done
raclim
approved these changes
Nov 17, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks overall great to me! Thanks so much for working on this and sorry again for the delay!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just trying to break up components that are doing way too much.
Changes:
_renderCollectionMetadata
method ofCollection
to a new componentCollectionMetadata
.ShareURL
component to a separate file as it used byCollectionMetadata
but not byCollection
(anymore).I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123