Skip to content

Move CollectionMetadata into its own component. #2253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 17, 2023

Conversation

lindapaiste
Copy link
Collaborator

Just trying to break up components that are doing way too much.

Changes:

  • Move the code from the _renderCollectionMetadata method of Collection to a new component CollectionMetadata.
  • Move the existing ShareURL component to a separate file as it used by CollectionMetadata but not by Collection (anymore).
  • Fix a console warning:

Warning: validateDOMNesting(...): <div> cannot appear as a descendant of <p>.
in div (created by ShareURL)

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@lindapaiste lindapaiste mentioned this pull request Aug 13, 2023
4 tasks
@raclim raclim added this to the Next Release milestone Oct 18, 2023
Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely Done

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks overall great to me! Thanks so much for working on this and sorry again for the delay!

@raclim raclim merged commit 91062b5 into processing:develop Nov 17, 2023
@lindapaiste lindapaiste deleted the refactor/collection-details branch November 17, 2023 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants