Skip to content

Making 'Sublime Text shortcuts.' hyperlink easily distinguishable with rest of the text. #2940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Ri-Sharma opened this issue Jan 22, 2024 · 3 comments
Labels
Area:CSS For styling or layout issues handled with CSS/SASS Enhancement Improvement to an existing feature

Comments

@Ri-Sharma
Copy link
Contributor

Increasing Access

This would allow the user to easily identify that 'Sublime Text shortcuts' is an hyperlink.

Feature enhancement details

Before :-
image

After :-
image

@Ri-Sharma Ri-Sharma added the Enhancement Improvement to an existing feature label Jan 22, 2024
Ri-Sharma added a commit to Ri-Sharma/p5.js-web-editor-forked that referenced this issue Jan 22, 2024
@lindapaiste
Copy link
Collaborator

Issues like this keep coming up in various places and I think that we probably want to change the default style for all links, not just this one link. @raclim should we use the primary accent color (pink) for all links?

@lindapaiste lindapaiste added the Area:CSS For styling or layout issues handled with CSS/SASS label Jan 22, 2024
@raclim
Copy link
Collaborator

raclim commented Jan 25, 2024

@lindapaiste Hmm, I think the primary accent color might not work because it doesn't pass the color contrast criteria for accessibility.


Screenshot 2024-01-25 at 3 42 00 PM

I think we actually have a lot of elements within the site that definitely don't pass this 😅 particularly, the dark grey text on light grey backgrounds. I've been wondering in terms of appearance, if it might be better to reach out to a designer who can give a clear direction on how all these elements should look that also aligns with these standards?

@Noorain464
Copy link

I am new to open source and I would like to work on it

@raclim raclim closed this as not planned Won't fix, can't repro, duplicate, stale Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area:CSS For styling or layout issues handled with CSS/SASS Enhancement Improvement to an existing feature
Projects
None yet
4 participants