Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Insufficient hover effect on console Clear button #2592

Open
avengsum opened this issue Nov 11, 2023 · 8 comments · May be fixed by #3278
Open

Insufficient hover effect on console Clear button #2592

avengsum opened this issue Nov 11, 2023 · 8 comments · May be fixed by #3278
Labels

Comments

@avengsum
Copy link

avengsum commented Nov 11, 2023

p5.js version

v1.8.0

What is your operating system?

Windows

Web browser and version

119.0.6045.124

Actual Behavior

while hovering the cursor over the Clear button the background color is not visible properly
Screenshot 2023-11-11 143108

Expected Behavior

we should increase its intensity so that we can see properly

Steps to reproduce

Steps:

  1. Go to p5.js editor
  2. Try to hover over the clear button
@avengsum avengsum added the Bug label Nov 11, 2023
Copy link

welcome bot commented Nov 11, 2023

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, be sure to follow the issue template if you haven't already.

@avengsum avengsum changed the title Hovering the cursor over Clear does not change the background text color Hovering the cursor over Clear does change the background color but it is not properly visible to naked eyes Nov 11, 2023
@avengsum avengsum reopened this Nov 11, 2023
@avengsum avengsum changed the title Hovering the cursor over Clear does change the background color but it is not properly visible to naked eyes Hovering the cursor over the Clear button does change the background color but it is not properly visible to naked eyes Nov 11, 2023
@mhsh312
Copy link
Contributor

mhsh312 commented Nov 11, 2023

are you saying the hover shadow should be bigger?

@Garima3110
Copy link
Member

Garima3110 commented Nov 11, 2023

are you saying the hover shadow should be bigger?

well, i think @avengsum is referring to using a darker color for the hover effect so that it is visible clearly.

@lindapaiste lindapaiste added Area: Design Status: Needs Discussion Area:Accessibility Category for accessibility related features and bugs and removed Bug labels Nov 12, 2023
@lindapaiste
Copy link
Collaborator

Let's discuss what we think it should look like when hovered!

The current effect is that the text color gets a little darker. There is no change to the background color. That is similar to the chevron open/close icon button next to it, but the color change is much more noticeable on the icon because the lines are thicker.

We could make the text bold when hovered. That might be weird because there's a little bit of movement due to bold text being larger/wider. But it definitely makes the hover very noticeable.
image

We could change the text color to the primary color (pink) like we do on menu items. This is not particularly readable but it shows that you are interacting with something clickable.
image

A bolder move would be to make the whole background pink on hover. Similar to the button for the sidebar files. This involves some tweaks to the border-radius, padding, etc.
image
If we do this, then I think we would want a stronger effect on the chevron open/close button that is next to it as well. So this could involve a lot of changes.

The CSS I'm playing with in dev tools for that mockup is

.light .preview-console__clear:hover {
    background: #ed225d;
    color: white;
    padding: 2px 6px;
    border-radius: 2px;
    margin-right: 4px;
}

@lindapaiste lindapaiste changed the title Hovering the cursor over the Clear button does change the background color but it is not properly visible to naked eyes Insufficient hover effect on console Clear button Nov 12, 2023
@mhsh312
Copy link
Contributor

mhsh312 commented Nov 13, 2023

I think what we should do is:
-Make the text #ed225d on hover
-Also add a #ed225d solid shadow to it so that it increases visibility (kinda like bold) but it doesn't look jarring like when making it bold as shadow doesn't move the text like bold does.

That way we are following the theme of p5 and making sure readable.

Code:

.light .preview-console__clear:hover {
    color: #ed225d;
    text-shadow: 0.25px -0.25px 0px #ed225d, 0.25px 0.25px 0px #ed225d, -0.25px 0.25px 0px #ed225d, 0.25px -0.25px 0px #ed225d;
}

Output:
image

If not, I think changing the color to pink and making the text bold is the best option.

@yashpandey06
Copy link
Contributor

I will suggest changing of the text color rather than making it whole background colored .

@PiyushChandra17
Copy link
Contributor

Well, I think the second option what @lindapaiste proposed ie. just changing the text color will work fine.

@ujjwaldubey1
Copy link

I agree with you @PiyushChandra17 because @lindapaiste had previously said that if we make the text bolder then the size feels it is increasing so the text bold thing don't work for us for this time so the background color change would be the great option to do.

@ujjwaldubey1 ujjwaldubey1 linked a pull request Nov 17, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
7 participants