Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

changed the color of clear button #f2592 #2598

Closed
wants to merge 1 commit into from
Closed

changed the color of clear button #f2592 #2598

wants to merge 1 commit into from

Conversation

avengsum
Copy link

Fixes #2592

Changes:
changed the color of clear text

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

PiyushChandra17
PiyushChandra17 approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@raclim
Copy link
Collaborator

raclim commented Jan 25, 2024

Thanks for working on this! I think a consensus for what the "Clear" button would look like wasn't finalized yet in the associated issue, so I'm going to close this for now. Please feel free to reopen this or create a new issue once it's decided!

@raclim raclim closed this Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PiyushChandra17 PiyushChandra17 PiyushChandra17 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Insufficient hover effect on console Clear button
3 participants
@avengsum @raclim @PiyushChandra17