Skip to content

My assets modal does not show orphaned assets #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 3 tasks
francisli opened this issue Dec 7, 2017 · 1 comment
Closed
1 of 3 tasks

My assets modal does not show orphaned assets #498

francisli opened this issue Dec 7, 2017 · 1 comment
Milestone

Comments

@francisli
Copy link
Contributor

Nature of issue?

  • Found a bug
  • Existing feature enhancement
  • New feature request

Details about the bug:

Actually, not sure if it's a bug or intended behavior- if you start a new sketch, upload a file in the sidebar, but don't save your sketch, the file will still be in the S3 bucket, but will not appear in the "My assets" modal. In listObjectsInS3ForUser, only assets that are found in saved projects are listed.

Shouldn't all assets be returned, maybe with some sort of "orphaned" indicator, so that they can be deleted by the user?

@catarak
Copy link
Member

catarak commented Dec 8, 2017

i think at first i thought that these shouldn't be returned, but thinking about this again, i agree, i think that these assets should be returned 😄

@catarak catarak added this to the Post-Release milestone Jun 19, 2019
catarak added a commit that referenced this issue Jun 19, 2019
catarak added a commit that referenced this issue Jul 22, 2019
* fixes #498

* fix linting errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants