Skip to content

Expose and link to slugified sketch titles #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 of 3 tasks
catarak opened this issue Feb 7, 2018 · 4 comments
Open
1 of 3 tasks

Expose and link to slugified sketch titles #524

catarak opened this issue Feb 7, 2018 · 4 comments
Labels
Feature Request Proposal for adding a new functionality Help Wanted Would love additional input or contributions! Priority:Medium Moderately important, should be completed in a fair timeframe

Comments

@catarak
Copy link
Member

catarak commented Feb 7, 2018

Nature of issue?

  • New feature request

New feature details:

Sketches, when they are saved to the server, generate a slug of the sketch title. It would be great to expose the slug links publicly, perhaps on the share modal.
Tasks:

  • Add link to share modal
  • Add slug attribute to existing sketches in mongo
@catarak catarak added Feature Request Proposal for adding a new functionality Priority:Medium Moderately important, should be completed in a fair timeframe labels Feb 7, 2018
@himanshuc3
Copy link
Contributor

I would like to take it up. But I dont know how to reproduce the share modal. Perhaps you could help me with this.

@catarak
Copy link
Member Author

catarak commented Feb 20, 2018

Save a sketch or open a saved sketch -> File -> Share

@catarak
Copy link
Member Author

catarak commented Oct 25, 2018

bumping this—would be amazing to have this!

@catarak catarak added Help Wanted Would love additional input or contributions! Good First Issue A beginner-friendly issue, great for first-time contributors labels Oct 25, 2018
catarak added a commit that referenced this issue Aug 9, 2019
@catarak
re: #524, slugify example titles so that they can have a permanent link
741f287
catarak added a commit that referenced this issue Aug 9, 2019
@catarak
re: #524, slugify example titles so that they can have a permanent link
25151e7
@catarak catarak removed the Good First Issue A beginner-friendly issue, great for first-time contributors label Feb 12, 2020
@catarak
Copy link
Member Author

catarak commented Feb 12, 2020

I had a thought about this, which is that this could be added as a setting. I'm imaging in the settings modal, there would now be three tabs:

  1. Sketch Settings
  2. Editor Settings
  3. Accessibility Settings

Sketch privacy could also live under "Sketch Settings" (#91).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature Request Proposal for adding a new functionality Help Wanted Would love additional input or contributions! Priority:Medium Moderately important, should be completed in a fair timeframe
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@catarak @himanshuc3