Skip to content

Long Files added to sketches appear empty #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 3 tasks
aferriss opened this issue Jun 4, 2018 · 5 comments
Closed
1 of 3 tasks

Long Files added to sketches appear empty #645

aferriss opened this issue Jun 4, 2018 · 5 comments
Labels
Priority:High Should be addressed soon but not critical
Milestone

Comments

@aferriss
Copy link

aferriss commented Jun 4, 2018

Nature of issue?

  • Found a bug
  • Existing feature enhancement
  • New feature request

Details about the bug:

When I upload a JSON file that's sufficiently long (I'm not sure what the limit is), the file will appear empty when I navigate to it via the sidebar. I can even go into the file and start writing more json and it doesn't interfere with the original invisible json. I'm not sure if it's limited to JSON or not. I think one of my students tried this with a CSV file and saw something similar but I haven't tested again to confirm.

This only happens if I upload the whole file. If I create an empty json file, and paste in my text there's no issue.

Sketch to demonstrate the bug below.

@catarak
Copy link
Member

catarak commented Jun 4, 2018

thanks for reporting this! this is basically a UI/UX bug. what's happening here is that the files are so big that they are being uploaded to S3, but the UX doesn't reflect that—it just appears that the files are empty. this is handled in the new design, but it would be nice to put something sooner so that it doesn't seem like a bug 😄

@catarak catarak added type:bug Priority:High Should be addressed soon but not critical labels Jun 4, 2018
@catarak catarak added this to the Public Release milestone Jun 4, 2018
@catarak catarak modified the milestones: Public Release, Post-Release Oct 25, 2018
@kylemcdonald
Copy link

I also see this. My workaround was to host the file elsewhere and refer to the remote location. For workshops the "empty" file felt too confusing.

@catarak
Copy link
Member

catarak commented Nov 5, 2018

yeah this is super confusing! i added this issue to the current milestone so it should be fixed relatively soon.

@siddhant1
Copy link
Contributor

Will take a look on this

@catarak
Copy link
Member

catarak commented Jun 12, 2019

just pushed a fix for this in #1102.

@catarak catarak closed this as completed Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority:High Should be addressed soon but not critical
Projects
None yet
Development

No branches or pull requests

4 participants