Skip to content

"Add folder" button creates a folder which opens to the side in the code editor #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
GaurangTandon opened this issue Mar 18, 2019 · 5 comments
Labels
Good First Issue A beginner-friendly issue, great for first-time contributors Help Wanted Would love additional input or contributions! Priority:High Should be addressed soon but not critical

Comments

@GaurangTandon
Copy link
Contributor

Nature of issue?

  • Found a bug

Details about the bug:

  • Web browser and version: Chrome latest
  • Operating System: Ubuntu 18.04
  • Steps to reproduce this bug:
  1. Open a new sketch and click the dropdown for "project-folder"
  2. Click Add folder and add a new folder.
  3. Click on the newly folder in the explorer.

Result: folder is editable in the code editor!

image

This behaviour is definitely confusing me. What should be the result of editing a folder in this manner be?

Is this is a bug? I think it is, but I'll wait for @catarak to confirm.
And if it is a bug, I'd like to work on it. Thanks!

PS: A relatively minor related issue is that a newly added folder has - as its icon - a solid down arrow instead of the folder icon it is supposed to have.

@AnkurIngale
Copy link
Contributor

It might be a bug but it's a good way to document things up in that folder 😅

@catarak
Copy link
Member

catarak commented Mar 20, 2019

this is related to #645. for folders, long files, and assets, the code editor should be replaced with something else 😄

@catarak catarak added type:bug Help Wanted Would love additional input or contributions! Priority:High Should be addressed soon but not critical Good First Issue A beginner-friendly issue, great for first-time contributors labels Mar 20, 2019
@GaurangTandon
Copy link
Contributor Author

@catarak What do you think should it display? Would a simple "Sorry, the file type is unsupported in our editor." suffice? I can work to incorporate it.

@AnkurIngale
Copy link
Contributor

Yeah it's a bug. But honestly speaking, it's good. I mean I can document things of that folder there. No need to create text files. Maybe it's just me being lazy 😅

@catarak
Copy link
Member

catarak commented Mar 21, 2019

it shouldn't be an error. one solution would be that folders can't be selected, and when you click on them, it simply opens/closes the folder. #963 would need to be fixed first though.

catarak added a commit that referenced this issue Jun 12, 2019
catarak added a commit that referenced this issue Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue A beginner-friendly issue, great for first-time contributors Help Wanted Would love additional input or contributions! Priority:High Should be addressed soon but not critical
Projects
None yet
Development

No branches or pull requests

3 participants