Skip to content

Updating assets #734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
slowizzm opened this issue Oct 18, 2018 · 10 comments
Closed

Updating assets #734

slowizzm opened this issue Oct 18, 2018 · 10 comments
Labels
Feature Request Proposal for adding a new functionality Priority:Low Low-impact issue that can be addressed after higher-priority tasks

Comments

@slowizzm
Copy link

  • [x ] Existing feature enhancement

Instead of adding a -# to the end of a file that is being re-uploaded (or more specifically a file that has the same name as an existing file in the project), it would be nice if it would just overwrite that existing file.

@slowizzm slowizzm changed the title Updating Updating assets Oct 18, 2018
@catarak
Copy link
Member

catarak commented Oct 18, 2018

thanks for reporting! i think it would be confusing if it just overwrote the old asset. however, maybe this can function like in an operating system—the editor could show an alert, asking if the user wants to overwrite the file or keep both.

@catarak catarak added Feature Request Proposal for adding a new functionality Priority:Medium Moderately important, should be completed in a fair timeframe labels Oct 18, 2018
@slowizzm
Copy link
Author

Yes, I agree. An alert would be best to prevent user error.

@catarak catarak added Priority:Low Low-impact issue that can be addressed after higher-priority tasks and removed Priority:Medium Moderately important, should be completed in a fair timeframe labels Oct 22, 2018
@LakshSingla
Copy link
Contributor

@catarak I would like to work on this issue. Can you please help me with which functions needs refactoring. Also, the only method I know to add a file in the ide is to click on the new file or new folder dragdown, in the sidepane. Are there any other methods to achieve it?

@slowizzm
Copy link
Author

slowizzm commented Nov 8, 2018

Yes, that is the only method I know of to upload files. I have also noticed that you can only upload 6 files at a time.

@LakshSingla
Copy link
Contributor

@catarak @slowizzm I found the redux action responsible for producing the unique filename. Is there any pre existing modal I can reuse for issuing the warning?

@catarak
Copy link
Member

catarak commented Nov 8, 2018

yeah! i would use the component client/modules/App/components/Overlay.jsx. Maybe it would make sense for the overlay to have a few buttons which say "Keep Both", "Replace", "Cancel", and then the "X" would also cancel.

LakshSingla added a commit to LakshSingla/p5.js-web-editor that referenced this issue Nov 9, 2018
…#734)

 - Add a check in the createFile action for repeated files

 - Add a NameCollisionModal.jsx[WIP] and corresponding reducers and actions to show and hide it
@catarak
Copy link
Member

catarak commented Dec 12, 2019

in my opinion, the amount of effort it would take to work on this issue exceeds its benefit, and therefore i think it makes sense to close this issue. feel free to reopen if you think otherwise!!

@catarak catarak closed this as completed Dec 12, 2019
@slowizzm
Copy link
Author

@catarak That makes sense. I would like to say that I have students every semester frustrated with this because they often need to re-edit their assets and when some of those assets are image sequences this can be a tedious process. One solution for this is for me to just have them work in vs code, but then that takes them out of the p5 environment and I love using this editor as a teaching tool for art and media students new to code.

I will let you be the judge to re-open, as I am sure there are higher-priorities needing attention.

@catarak
Copy link
Member

catarak commented Dec 13, 2019

got it! maybe the solution here is not being able to edit assets, but for the flow for uploading/renaming/deleting assets to be easier.

@slowizzm
Copy link
Author

slowizzm commented Dec 13, 2019

@catarak Yes, that sounds like a plausible solution. Sounds like this may be relative to being the able to the re-order/drag files into folders issue, not sure what issue that is but I have seen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Request Proposal for adding a new functionality Priority:Low Low-impact issue that can be addressed after higher-priority tasks
Projects
None yet
Development

No branches or pull requests

3 participants