Skip to content

Multiple File Options #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nimishagarwal76 opened this issue Mar 25, 2019 · 1 comment
Closed

Multiple File Options #987

nimishagarwal76 opened this issue Mar 25, 2019 · 1 comment

Comments

@nimishagarwal76
Copy link
Contributor

nimishagarwal76 commented Mar 25, 2019 •
edited
Loading

Nature of issue?

  • Found a bug

Details about the bug:

Latest Merge Fixed Issue #659 (#964) causes multiple menus to remain open.
Screenshot (1)

#876 removed the issue but it comes again now.
@nimishagarwal76 nimishagarwal76 changed the title Multiple Menu Multiple File Options Mar 25, 2019
@Marton6
Copy link
Contributor

Marton6 commented Mar 25, 2019

Hello! I would like to work on this issue.

Marton6 added a commit to Marton6/p5.js-web-editor that referenced this issue Mar 25, 2019
@Marton6
Fix multiple file options showing up (processing#987)
ef69c13 
This change ensures that the file options composite widget is
hidden if and only if none of its components is in focus. This
is achieved by having a variable keep track of the state of
the composite widget (in focus / not in focus).
Marton6 added a commit to Marton6/p5.js-web-editor that referenced this issue Mar 26, 2019
@Marton6
Fix processing#987
7819fcc 
Modified fix for processing#987 according to the requested changes.
Moved isFocused to the components state and created a method
for hadling the function calls executed in onBlur.
Marton6 added a commit to Marton6/p5.js-web-editor that referenced this issue Mar 27, 2019
@Marton6
Fix processing#987 - final touches
adc2d05 
Renamed method blurComponent to onBlurComponent. Moved duplicated
code from onFocus callback to a new method called onFocusComponent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Marton6 @nimishagarwal76