Email Validation added #1120
Merged
Email Validation added #1120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catarak
requested changes
Jul 18, 2019
| errors.email = 'Please enter an email.'; | ||
| } else if ( | ||
| // eslint-disable-next-line max-len | ||
| !formProps.email.match(/^(([^<>()[\]\\.,;:\s@"]+(\.[^<>()[\]\\.,;:\s@"]+)*)|(".+"))@((\[[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}\.[0-9]{1,3}])|(([a-zA-Z\-0-9]+\.)+[a-zA-Z]{2,}))$/i)) { |
There was a problem hiding this comment.
there's a file called client/utils/reduxFormUtils.js that has validation functions, including a regex to validate an email address. i would put a function in there and use that regex!
There was a problem hiding this comment.
@catarak Okay, I will use that file functions for validations.
|
thanks for working on this issue! |
… into email-validation
|
@catarak Please review it :) |
catarak
requested changes
Jul 22, 2019
catarak
requested changes
Jul 22, 2019
|
this works great. merging now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified that this pull request:
Fixes #1119
npm run lint)Fixes #123@catarak Please review it :)