Update IDEView.jsx #1230
Merged
Update IDEView.jsx #1230
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`<Overlay...` has a default `title` of `'Modal'` https://github.com/processing/p5.js-web-editor/blob/master/client/modules/App/components/Overlay.jsx#L102 many modals are missing a title, so i added some. i made them basically the same as the `ariaLabel` (but capitalized, changed `-` to ` `, etc)
Member
|
thank you! in the future it would be helpful if you opened an issue before opening a pull requests—it's better for documentation bugs/features in the project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<Overlay...has a defaulttitleof'Modal'https://github.com/processing/p5.js-web-editor/blob/master/client/modules/App/components/Overlay.jsx#L102
many modals are missing a title, so i added some. i made them basically the same as the
ariaLabel(but capitalized, changed-to