Skip to content

Conversation

@gabrielsroka
Copy link
Contributor

<Overlay... has a default title of 'Modal'
https://github.com/processing/p5.js-web-editor/blob/master/client/modules/App/components/Overlay.jsx#L102

many modals are missing a title, so i added some. i made them basically the same as the ariaLabel (but capitalized, changed - to , etc)

`<Overlay...` has a default `title` of `'Modal'`
https://github.com/processing/p5.js-web-editor/blob/master/client/modules/App/components/Overlay.jsx#L102

many modals are missing a title, so i added some. i made them basically the same as the `ariaLabel` (but capitalized, changed `-` to ` `, etc)
@catarak
Copy link
Member

catarak commented Jan 9, 2020

thank you! in the future it would be helpful if you opened an issue before opening a pull requests—it's better for documentation bugs/features in the project.

@catarak catarak merged commit b8d47c6 into processing:master Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants