Skip to content

Conversation

@ashu8912
Copy link
Contributor

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest master. (If I was asked to make more changes, I have made sure to rebase onto master then too)
  • is descriptively named and links to an issue number, i.e.
    Fixes Every InlineSVG is missing an aria-label #1259

@ashu8912 ashu8912 closed this Feb 13, 2020
@ashu8912 ashu8912 reopened this Feb 13, 2020
@ashu8912 ashu8912 requested review from andrewn, catarak and yining1023 and removed request for andrewn February 13, 2020 17:20
@ashu8912
Copy link
Contributor Author

Though This Might Not Be the Best Feature But This certainly gives boost to accessibility earlier every svg was having a wrong title but now they have correct title and helps screen readers a lot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Every InlineSVG is missing an aria-label

1 participant