Skip to content

Conversation

@catarak
Copy link
Member

@catarak catarak commented Jan 28, 2021

RE #625

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

I'm not sure this totally fixes all of the webpack issues, but it has definitely made the build faster. I think that updating webpack to v5 will also likely help, and this PR definitely is a step on that path.

@catarak catarak merged commit 319c90f into develop Jan 29, 2021
@catarak catarak deleted the chore/webpack-linting branch January 29, 2021 20:23
catarak added a commit that referenced this pull request Feb 2, 2021
[#1745] move eslint-webpack-plugin to dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants