Skip to content

Bug/interactive console 2 #1796

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 12, 2021
Merged

Bug/interactive console 2 #1796

merged 4 commits into from
Mar 12, 2021

Conversation

catarak
Copy link
Member

@catarak catarak commented Mar 10, 2021

Fixes #667, #1684

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and has been rebased on top of the latest develop branch. (If I was asked to make more changes, I have made sure to rebase onto develop then too)
  • is descriptively named and links to an issue number, i.e. Fixes #123

for whatever reason I can't make this into a draft PR, but this still needs some review to figure out why it breaks in production but nowhere else

@catarak catarak marked this pull request as draft March 10, 2021 23:21
@release-com
Copy link

release-com bot commented Mar 10, 2021

Release Environments

p5.js-web-editor
app-tedae93-p5-js-web-editor.releaseapp.io

@catarak
Copy link
Member Author

catarak commented Mar 11, 2021

i figured it out!!! the reason is that the file previewScripts.js is getting cached to its old version!!! so I guess the thing to figure out is how to cache bust it :)

@catarak catarak marked this pull request as ready for review March 11, 2021 22:58
@catarak catarak merged commit 7ed0370 into develop Mar 12, 2021
@catarak catarak deleted the bug/interactive-console-2 branch March 12, 2021 17:51
catarak added a commit that referenced this pull request Apr 6, 2021
[#1796] update message structure sent from onerror and onunhandledrejection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant