Feature: Preview uploaded files in the editor #2232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #57
Changes:
AssetPreview
component which is rendered inside the editor container when the user clicks on a file with aurl
(that is, an asset uploaded to S3).mime
(which we use on the server).image/*
=><img>
elementvideo/*
=><video>
elementaudio/*
=><audio>
elementI might need to tweak the CSS for images which are taller than they are wide. I'm using
max-width: 100%; height: auto;
for both image and video.I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123