Skip to content

favicon #2381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lindapaiste merged 2 commits into from
Aug 15, 2023
Merged

favicon #2381

lindapaiste merged 2 commits into from
Aug 15, 2023

Conversation

@sdivyanshu90
Copy link
Contributor

@sdivyanshu90 sdivyanshu90 commented Aug 15, 2023 •
edited
Loading

Fixes #2140

Changes:
Changed the relative path to the absolute path

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is descriptively named and links to an issue number, i.e. Fixes #2140

@sdivyanshu90
Copy link
Contributor Author

sdivyanshu90 commented Aug 15, 2023

Hi @lindapaiste, could you review my pull request and provide feedback? Thanks!

@lindapaiste
Copy link
Collaborator

lindapaiste commented Aug 15, 2023

Thanks for fixing this!

@lindapaiste lindapaiste merged commit f398e76 into processing:develop Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@lindapaiste lindapaiste lindapaiste approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

No favicon

2 participants

@sdivyanshu90 @lindapaiste