Skip to content

Fix for Build Breaking When Deployed to Release #2507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Oct 18, 2023
Merged

Fix for Build Breaking When Deployed to Release #2507

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
cfd67f8
remove unused import in IDEView.jsx
raclim Oct 11, 2023
940968e
test deployment with conditional import
raclim Oct 12, 2023
60a1c5f
replace null with empty object for conditional import
raclim Oct 12, 2023
9321d6f
revert back import changes
raclim Oct 12, 2023
3926375
comment out route proptypes
raclim Oct 12, 2023
62e5d17
remove unused action in IDEView
raclim Oct 12, 2023
d52d64c
remove TypeError for undefined property
raclim Oct 15, 2023
90c3f71
temporarily comment out lines involving isOverlayVisible
raclim Oct 17, 2023
92fae12
set initial state for isOverlayVisible and setIsOverlayVisible to false
raclim Oct 18, 2023
fecadb5
rewrite assignments for Route.propTypes
raclim Oct 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions client/modules/IDE/pages/IDEView.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ import PreviewFrame from '../components/PreviewFrame';
import Console from '../components/Console';
import Toast from '../components/Toast';
import { updateFileContent } from '../actions/files';
import { stopSketch } from '../actions/ide';

import {
autosaveProject,
clearPersistedState,
Expand Down Expand Up @@ -80,7 +80,7 @@ const IDEView = () => {

const [consoleSize, setConsoleSize] = useState(150);
const [sidebarSize, setSidebarSize] = useState(160);
const [isOverlayVisible, setIsOverlayVisible] = useState(true);
const [isOverlayVisible, setIsOverlayVisible] = useState(false);

const cmRef = useRef({});

Expand All @@ -93,8 +93,6 @@ const IDEView = () => {

useEffect(() => {
dispatch(clearPersistedState());

dispatch(stopSketch());
}, [dispatch]);

useEffect(() => {
Expand Down Expand Up @@ -160,7 +158,6 @@ const IDEView = () => {
setIsOverlayVisible(true);
}}
onDragFinished={() => {
// overlayRef.current.style.display = 'none';
setIsOverlayVisible(false);
}}
resizerStyle={{
Expand Down
6 changes: 4 additions & 2 deletions client/routes.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,8 +48,10 @@ const withParams = (Component) => (props) => (
const Route = ({ component, ...props }) => (
<RouterRoute component={withParams(component)} {...props} />
);
Route.propTypes = { ...RouterRoute.propTypes };
Route.propTypes.component = PropTypes.elementType.isRequired;
Route.propTypes = {
...RouterRoute.propTypes,
component: PropTypes.elementType.isRequired
};

const routes = (
<Switch>
Expand Down
56 changes: 16 additions & 40 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@
"@babel/plugin-transform-react-inline-elements": "^7.14.5",
"@babel/preset-env": "^7.14.7",
"@babel/preset-react": "^7.14.5",
"@pmmmwh/react-refresh-webpack-plugin": "^0.5.10",
"@storybook/addon-actions": "^7.0.24",
"@storybook/addon-docs": "^7.0.24",
"@storybook/addon-essentials": "^7.0.27",
Expand Down Expand Up @@ -159,6 +158,7 @@
"@babel/register": "^7.14.5",
"@emmetio/codemirror-plugin": "^1.2.4",
"@gatsbyjs/webpack-hot-middleware": "^2.25.3",
"@pmmmwh/react-refresh-webpack-plugin": "^0.5.11",
"@redux-devtools/core": "^3.11.0",
"@redux-devtools/dock-monitor": "^2.1.0",
"@redux-devtools/log-monitor": "^3.1.0",
Expand Down