Moved Search bar to be a functional component #2509
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
PiyushChandra17
approved these changes
Oct 19, 2023
Contributor
PiyushChandra17
left a comment
PiyushChandra17
left a comment
There was a problem hiding this comment.
Looks good to me
Author
|
hey what will be next process for merging this pull Request
…On Thu, Oct 19, 2023 at 8:25 PM PiyushChandra17 ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good to me
—
Reply to this email directly, view it on GitHub
<#2509 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4YNWZ3AXUTGPMORDHDYYGDYAE5NHAVCNFSM6AAAAAA6DZ7QQKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMOBXHE3TMMZZGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
raclim
added
the
Area: Code Quality
Collaborator
|
Thanks for your work on this! This issue ultimately was addressed by PR #2431, so I'm going to close this one. I'm sorry that we couldn't get this in, but please feel free to check out our other issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2358
Changes:
Ref #2358
Description:
The issue was that the search bar was not a functional component, leading to performance issues. I refactored the code to move the search bar into a functional component, improving the performance and maintainability of the code
Changes Made:
Moved the search bar to be a functional component.
Verification:
I have verified that this pull request:
npm run lint)npm run test)karan/searchBarbranch.Ref #2358