-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Trigger Immediate Refresh when ticking the Auto-Refresh checkbox #2522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
is anything else we want @raclim . Please review the PR whenever you are free @raclim @lindapaiste |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Thankyou |
Hey @perminder-17 thanks for your contributions! Just a friendly note: Could you please use more descriptive names for your Pull Requests? It helps maintainers review your work more efficiently. For instance, I've renamed your PR from Keep up the great work! |
Thankyou so much @SableRaf . I am going to change the names of other Pull Requests name ASAP. Thanks for your suggestion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Just a note that there are other possible places in the code where this could be addressed, such as handling it inside the setAutoRefresh
action.
Ok @lindapaiste I will take care of it next time. |
Fixes #2511
Changes:
issuelast.webm
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123