Skip to content

Trigger Immediate Refresh when ticking the Auto-Refresh checkbox #2522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 25, 2023

Conversation

perminder-17
Copy link
Contributor

@perminder-17 perminder-17 commented Oct 20, 2023

Fixes #2511

Changes:

issuelast.webm

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@perminder-17
Copy link
Contributor Author

is anything else we want @raclim . Please review the PR whenever you are free @raclim @lindapaiste

Copy link
Contributor

@PiyushChandra17 PiyushChandra17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@perminder-17
Copy link
Contributor Author

Looks good to me

Thankyou

@SableRaf SableRaf changed the title solved for issue #2511 Trigger Immediate Refresh when ticking the Auto-Refresh checkbox Oct 30, 2023
@SableRaf
Copy link
Contributor

Hey @perminder-17 thanks for your contributions!

Just a friendly note: Could you please use more descriptive names for your Pull Requests? It helps maintainers review your work more efficiently.

For instance, I've renamed your PR from solved for issue #2511 to Trigger Immediate Refresh when ticking the Auto-Refresh checkbox.

Keep up the great work!

@perminder-17
Copy link
Contributor Author

Thankyou so much @SableRaf . I am going to change the names of other Pull Requests name ASAP. Thanks for your suggestion.

Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Just a note that there are other possible places in the code where this could be addressed, such as handling it inside the setAutoRefresh action.

@lindapaiste lindapaiste merged commit f508f52 into processing:develop Nov 25, 2023
@perminder-17
Copy link
Contributor Author

Looks good!

Just a note that there are other possible places in the code where this could be addressed, such as handling it inside the setAutoRefresh action.

Ok @lindapaiste I will take care of it next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Auto-Refresh Button Doesn't Trigger Immediate Refresh
5 participants