Fixes #2524, Close create file menu when clicking outside #2525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
|
The final output will look like this. Screencast.from.2023-10-21.20-11-46.webm |
lindapaiste
approved these changes
Oct 22, 2023
There was a problem hiding this comment.
This looks fine. I hate that we have such similar code in so many components and I wrote a utility hook to fix that, but that PR still has not been merged 🙃 So I guess we should merge this to fix the immediate problem. (I can merge your PR but not my own).
I haven't loaded up your branch and run it yet. I will do that before merging but I'm approving it now because the code looks good.
lindapaiste
changed the title
PiyushChandra17
approved these changes
Oct 28, 2023
4 tasks
raclim
changed the title
|
Thanks for working on this! We ultimately ended up merging another fix for this, so I'm going to close this PR and issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2524
Changes:
Fix: clicking anywhere will close the menu of creating and deleting file and folder.
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123