Fix/#2609 'About' translation fixes

[umangutkarsh]

Addresses #2609

Changes:

• About.Home
• About.Twitter
• About.Instagram
• About.Discord
• About.PrivacyPolicy
• About.TermsOfUse
• About.CodeOfConduct
• About.WebEditor

I have verified that this pull request:

• has no linting errors (npm run lint)
• has no test errors (npm run test)
• is from a uniquely-named feature branch and is up to date with the develop branch.
• is descriptively named and links to an issue number, i.e. Fixes #123

[umangutkarsh]

@lindapaiste @mhsh312 . Please take out your time and review the pr. Thanks

[lindapaiste]

Thanks for identifying these untranslated phrases! Since we are moving from a hard-coded string to a translation we need to add the current texts to the English translations.json file. Can you please do that?

[umangutkarsh]

Sure @lindapaiste . I've added the texts to english translation.json file. But now I think some changes need to be done in other translations.json files also. What do you think?
Thanks for your time.

[lindapaiste]

@umangutkarsh @Somesh001yt @apsinghdev @Swarnendu0123 @mhsh312
Can I get you to review each other's Hindi translations? We have two open PRs and #2685 and #2690 for the autocomplete preference with slightly different texts. Which is better? There's this PR (#2691) and #2675 for the About modal.

[umangutkarsh]

Sure @lindapaiste . I've added the texts to english translation.json file. But now I think some changes need to be done in other translations.json files also. What do you think? Thanks for your time.

Some text need to be added in other translations.json files also. Ex: In Bengali, 'Home, Twitter, Instagram, and Discord' are written in english. Should that be changed?

[umangutkarsh]

@umangutkarsh @Somesh001yt @apsinghdev @Swarnendu0123 @mhsh312 Can I get you to review each other's Hindi translations? We have two open PRs and #2685 and #2690 for the autocomplete preference with slightly different texts. Which is better? There's this PR (#2691) and #2675 for the About modal.

@lindapaiste . In PR #2685 , It is written in absolute Hindi and as a native hindi speaker I think it is confusing. We should translate in such hindi words/phrases that are prevalent and known by majority of the Hindi-speaking people. ( simply the hindi words that we use in daily basis ).

If I imagine myself as a Hindi-speaking user of the web editor who doesn't know English, then I would know what 'Autocomplete Hinter' is and what it does. The only problem I would face is that I am not able to read 'Autocomplete Hinter' and understand what is written (because it's in English). So, if it's just written as 'ऑटोकम्प्लीट हिंटर,' it may solve my problem because now I would be able to read it, and if not understood, then I could Google it (because now it's in Hindi).

[lindapaiste]

Sure @lindapaiste . I've added the texts to english translation.json file. But now I think some changes need to be done in other translations.json files also. What do you think? Thanks for your time.

Over time we definitely want to translate these texts to every languages but that shouldn't get in the way of merging this. My general criteria for approving a PR is that it makes something better and doesn't make anything worse and you have done that here. Those phrases are in English 100% of the time right now but you've given us the capability to translate them which we didn't have before so it's an improvement.

FYI one of my goals for the future is to figure out better systems for managing translations.

[lindapaiste]

Sure @lindapaiste . I've added the texts to english translation.json file. But now I think some changes need to be done in other translations.json files also. What do you think? Thanks for your time.

Some text need to be added in other translations.json files also. Ex: In Bengali, 'Home, Twitter, Instagram, and Discord' are written in english. Should that be changed?

If you speak Bengali then you can add those translations. Don't worry about all the other languages.

[umangutkarsh]

@umangutkarsh @Somesh001yt @apsinghdev @Swarnendu0123 @mhsh312 Can I get you to review each other's Hindi translations? We have two open PRs and #2685 and #2690 for the autocomplete preference with slightly different texts. Which is better? There's this PR (#2691) and #2675 for the About modal.

@lindapaiste . In PR #2685 , the hindi translation dosen't make sense. It is written in absolute Hindi and as a native hindi speaker I think it is confusing. We should translate in such hindi words/phrases that are prevalent and known by majority of the Hindi-speaking people. ( simply the hindi words that we use in daily basis ).

If I imagine myself as a Hindi-speaking user of the web editor who doesn't know English, then I would know what 'Autocomplete Hinter' is and what it does. The only problem I would face is that I am not able to read 'Autocomplete Hinter' and understand what is written (because it's in English). So, if it's just written as 'ऑटोकम्प्लीट हिंटर,' it may solve my problem because now I would be able to read it, and if not understood, then I could Google it (because now it's in Hindi).

Same for PR #2675 and PR #2691 . Both are almost same but in #2691 some more texts like - instagram, twitter, home, discord, etc are added and converted in hindi.
Thanks for your time.

[Swarnendu0123]

@umangutkarsh @Somesh001yt @apsinghdev @Swarnendu0123 @mhsh312 Can I get you to review each other's Hindi translations? We have two open PRs and #2685 and #2690 for the autocomplete preference with slightly different texts. Which is better? There's this PR (#2691) and #2675 for the About modal.

#2685 is the actual translation of 'autocomplete hinter', but #2690 is only the hindi pronunciation english of 'autocomplete hinter' not the actual translation, well I feel the more appropriate for a native speaker of hindi is #2690, because in daily life we are more familiar with english terms, and in daily life we don't use pure hindi.

and for the About Object I feel PR #2691 (this PR) is good to go.

[Swarnendu0123]

Sure @lindapaiste . I've added the texts to english translation.json file. But now I think some changes need to be done in other translations.json files also. What do you think? Thanks for your time.

Some text need to be added in other translations.json files also. Ex: In Bengali, 'Home, Twitter, Instagram, and Discord' are written in english. Should that be changed?

If you speak Bengali then you can add those translations. Don't worry about all the other languages.

I am a Native Speaker of Bengali, may be I am the right Person to solve the issue #2692

[umangutkarsh]

@lindapaiste . If there are any issues in this PR which needs to be worked upon, please let me know.
Thanks.

[apsinghdev]

@umangutkarsh @Somesh001yt @apsinghdev @Swarnendu0123 @mhsh312 Can I get you to review each other's Hindi translations? We have two open PRs and #2685 and #2690 for the autocomplete preference with slightly different texts. Which is better? There's this PR (#2691) and #2675 for the About modal.

I think the only different in PR #2691 and PR #2675 is the number of translations. In PR #2675,I have added and translated the About phrases that were mentioned in #2609. And In PR #2691 @umangutkarsh added and translated some extra phrases that he probably thought are important like Twitter Instagram etc. So in my opinion, The consideration of better changes should be based on whether we have to add these extra phrases or not ? thanks.

[raclim]

Thanks for all of your input and work on this! I'm going to merge this in as is for now since there's a few additional translations here as well.

There's probably a better way to go about handling these translations 😅, but I think further changes to this could be made in new pull requests and issues down the line.