Fix screen reader features #2694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@raclim @Qianqianye @davepagurek @lindapaiste what do y'all think about this approach? |
davepagurek
reviewed
Dec 6, 2023
There was a problem hiding this comment.
Thanks for taking this on! I think this looks good, I just have one question (maybe for @lindapaiste?) about script tag order to try to handle as many cases as possible.
| }; | ||
| p5.prototype.registerMethod('afterSetup', p5.prototype.ensureAccessibleCanvas);`; | ||
| scriptElement.innerHTML = fxn; | ||
| sketchDoc.head.appendChild(scriptElement); |
There was a problem hiding this comment.
Do you think there's any harm in putting this at the end of the body in case people rearrange the imports of their sketch and import p5 in the body too?
There was a problem hiding this comment.
got it, I think this is good to go then!
lindapaiste
added
the
Area:Accessibility
davepagurek
approved these changes
Dec 7, 2023
|
@lindapaiste @davepagurek just checking in. Can I help to improve this pull request? Also curious to hear your thoughts on #2702 which would be affected. |
raclim
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2188
Changes:
I modified the
injectLocalFiles()function inclient/Preview/EmbedFrame.jsxto usetextOutput()andgridOutput().I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123