Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop-down closing issue fixed. #2704

Conversation

umangutkarsh
Copy link
Contributor

@umangutkarsh umangutkarsh commented Dec 9, 2023

Fixes #2703
Fixes #2683
Fixes #2524

Changes: The dropdown closing issue is fixed. Users can now click anywhere to close the menu of PlusIcon

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123
screen-capture.1.webm

@umangutkarsh
Copy link
Contributor Author

Maintainers, Please review this.

@raclim
Copy link
Collaborator

raclim commented Mar 28, 2024

Thanks for submitting this! I think the first two referenced issues have become resolved, and we're looking to go with a long term solution of refactoring the Dropdown menu to resolve the last issue (more info about it can be found in it). I'm sorry we aren't able to get this in, but please feel free to check out our other issues!

@raclim raclim closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment