Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted Editor Component to Functional #2710

Closed
wants to merge 4 commits into from

Conversation

Typicalcodes
Copy link
Contributor

@Typicalcodes Typicalcodes commented Dec 11, 2023

Fixes #2709

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • has no test errors (npm run test)
  • is descriptively named and links to an issue number

Copy link

release-com bot commented Dec 11, 2023

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-8ac594c6d2

@lindapaiste
Copy link
Collaborator

I haven't forgotten about this but I need to give it an extremely thorough review. I still have concerns about stale closures and missing hook dependencies. If you aren't familiar with the concept of stale closures here's an article to read as a starting point. We can't risk having any errors in such a core part of the app so we need to be 100% certain that every case is handled correctly.

@Typicalcodes
Copy link
Contributor Author

@lindapaiste thanks for the reply. I have gone through stale closure thing in past. But this is working fine in my local repo. Also I am doing a pr for consoleinput.jsx #2738 , look at that pr first so you can get the idea how i handeled stale closure.

@raclim raclim changed the title Converted Class Component to Functional. All bugs fixed. Converted Editor Component to Functional May 30, 2024
@raclim
Copy link
Collaborator

raclim commented Jul 3, 2024

Thanks for your work on this! We've decided to integrate this issue into a larger project that will be handled by a fellow over the summer, so I'm going to close this PR for now. I'm sorry that we couldn't get this in, but please feel free to check out our other issues!

@raclim raclim closed this Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Changing class component to Functional Component.
4 participants