Skip to content

fix username redirection on mWeb #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 3, 2024
Merged

fix username redirection on mWeb #2723

merged 3 commits into from
Jun 3, 2024

Conversation

PiyushChandra17
Copy link
Contributor

Fixes #2717

Changes:

  • Replaced h5 with <Link />
  • It will redirect to project.owner.username/sketches
fix-redirection.mp4

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@PiyushChandra17
Copy link
Contributor Author

@lindapaiste Can you please review this PR? If everything seems fine, then let's merge this. Thanks!

@raclim raclim added the Bug label Jan 26, 2024
@raclim raclim merged commit 99d0a88 into processing:develop Jun 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raclim raclim raclim approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mWeb (Safari) && mWeb(Chrome) - Tapping on sketch name by username redirects to nothing
2 participants
@PiyushChandra17 @raclim