Skip to content

Refactor: Resolve repeated code between server's previewGeneration.js and client's EmbedFrame.jsx #2820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Shyam-Raghuwanshi
Copy link

Fixes #2805

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Jan 1, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@lindapaiste lindapaiste added Area:Optimization Category for site performance optimization and management Area: Code Quality labels Jan 9, 2024
@raclim
Copy link
Collaborator

raclim commented Mar 29, 2024

Thanks for your work on this!

I think that although what's here so far does resolve the issue of repeated code between the two files, this doesn't address some of the other tasks listed in the issue (i.e "Add explanatory comments in the code, Add unit tests, Make improvements to the code itself...") that would help implement a more thorough, long-term solution.

Due to the number of PRs we have at the moment, I'm going to close this one for now. I'm sorry that we couldn't get this in yet, but please feel free to reopen this PR and update it with the needed changes, thanks!

@raclim raclim closed this Mar 29, 2024
@Shyam-Raghuwanshi Shyam-Raghuwanshi deleted the fix/repeated-code-preview branch March 29, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Code Quality Area:Optimization Category for site performance optimization and management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Repeated code between server previewGeneration.js and client EmbedFrame.jsx
3 participants