Skip to content

Update theme.js #2825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

RohitPaul0007
Copy link

@RohitPaul0007 RohitPaul0007 commented Jan 2, 2024

Fixes #issue-number

Changes:

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Copy link

welcome bot commented Jan 2, 2024

🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already.

@RohitPaul0007
Copy link
Author

can some one see the PR and give me feedback?

@lindapaiste
Copy link
Collaborator

can some one see the PR and give me feedback?

I think that you misunderstood the intention of the issue #2823. What you have done here is changed the pinks to yellows. We have 3 different themes, "light" "dark" and "contrast". We use pink as the primary accent color on "light" and "dark" and yellow as the primary accent color for "contrast". We definitely don't want to change that. We want to use a darker pink as the hover color for the "light" and "dark" themes and a darker yellow as the hover color for the "contrast" theme.

@lindapaiste lindapaiste closed this Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants