Skip to content

Feature/enhancement of hoverinig buttons #2883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 5, 2024

Conversation

haarsh157
Copy link
Contributor

@haarsh157 haarsh157 commented Jan 12, 2024

Fixes #2823, #2905

Changes:

  1. Changed hovering color to p5jsActivePink.
  2. Added new yellow color p5ContrastYellow and changed the button hovering color in the contrast theme.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #2823

Copy link

release-com bot commented Jan 12, 2024

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-3b7ecc2eba

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work on this!

I think overall this looks good! I made a few adjustments where I removed the changes to the RootPage.jsx file and the change to the foreground property in the theme.js file. I also feel that the p5jsActivePink color is not a noticeable enough difference to identify the hover state, but think that could be reconsidered down the line!

@raclim raclim merged commit 7982e3a into processing:develop Jun 5, 2024
1 check passed
@raclim raclim mentioned this pull request Jun 5, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Solid pink buttons need a hover effect
3 participants