Removed redundant redirects between client and server #2993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lindapaiste plz review this PR ,i have made the proposed changes. |
raclim
added
Area: Code Quality
|
@raclim could you please reveiw this PR since it has been open for a very long time |
|
@Mubashirshariq Sure, I'm sorry that it took some time! Would you be able to resolve some of the merge conflicts here first? |
|
@raclim sure will do that |
added 3 commits
June 14, 2024 18:50
…ttps://github.com/Mubashirshariq/p5.js-web-editor into Fix/Redundant_Redirects_between_server_and_client
|
@raclim done with resolving conflicts |
raclim
approved these changes
Jun 24, 2024
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2992
Changes:
Server Side:
Made changes on the server: Redirected "/sketches" and "/assets" to URLs with the username. Also, redirected "/reset-password" and "/reset-password/:reset_password_token" to "/account" if the user is logged in.
client :
Made changes on the client: Removed all Higher-Order Component (HOC) auth checks from routes.jsx, deleted createRedirectWithUsername component, and removed auth.js file.
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123