Skip to content

Conversation

PiyushChandra17
Copy link
Contributor

Associated Issue: #2042

Changes:

  • Deleted all the corresponding constants
  • Used createSlice to rewrite preferences reducers
  • Exported all the action creator functions

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

Sorry, something went wrong.

Verified

This commit was signed with the committer’s verified signature.
@raclim raclim added Type:Task Tasks tied specifically to developer operations and maintenance Enhancement Improvement to an existing feature labels Jun 3, 2024

Verified

This commit was signed with the committer’s verified signature.
Copy link
Collaborator

@lindapaiste lindapaiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wrote a lot on your other PRs so I'll keep this quick. I absolutely hate this actions file and I would love to see us take it a few steps further. I can set up a middleware that calls the preferences API whenever the state.preferences changes and then we don't need to define a separate thunk for every single action. We would be able to just dispatch the auto-generated actions directly.

@PiyushChandra17
Copy link
Contributor Author

I wrote a lot on your other PRs so I'll keep this quick. I absolutely hate this actions file and I would love to see us take it a few steps further. I can set up a middleware that calls the preferences API whenever the state.preferences changes and then we don't need to define a separate thunk for every single action. We would be able to just dispatch the auto-generated actions directly.

@lindapaiste This was my first thought aswell regarding the action file. We can directly dispatch these actions from the slices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvement to an existing feature Type:Task Tasks tied specifically to developer operations and maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants