refactor project reducers and actions using redux toolkit #3122
+67
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raclim
added
Type:Task
lindapaiste
reviewed
Jun 13, 2024
| state.isSaving = false; | ||
| }, | ||
| resetProject(state) { | ||
| Object.assign(state, initialState); |
Collaborator
There was a problem hiding this comment.
This isn't right because initialState is a function. It can be written as return initialState().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated issue: #2042
Changes:
constantscreateSliceto rewrite the project reduceractions/project.jsI have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123