Skip to content

fix semantic HTML #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2024
Merged

fix semantic HTML #3130

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e24f5f9
fix semantic HTML
PiyushChandra17 May 22, 2024
ed88fd6
Merge branch 'develop' into piyush/fix-semantic-HTML
raclim May 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client/modules/IDE/components/Editor/MobileEditor.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ export const EditorContainer = styled.div`
transform: ${(props) =>
props.expanded ? 'translateX(50%)' : 'translateX(0)'};

> header {
> div {
display: flex;
${prop('MobilePanel.secondary')}
> span {
Expand Down
8 changes: 4 additions & 4 deletions client/modules/IDE/components/Editor/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ class Editor extends React.Component {
{(matches) =>
matches ? (
<section className={editorSectionClass}>
<header className="editor__header">
<div className="editor__header">
<button
aria-label={this.props.t('Editor.OpenSketchARIA')}
className="sidebar__contract"
Expand All @@ -538,7 +538,7 @@ class Editor extends React.Component {
</span>
<Timer />
</div>
</header>
</div>
<article
ref={(element) => {
this.codemirrorContainer = element;
Expand All @@ -555,7 +555,7 @@ class Editor extends React.Component {
</section>
) : (
<EditorContainer expanded={this.props.isExpanded}>
<header>
<>
<IconButton
onClick={this.props.expandSidebar}
icon={FolderIcon}
Expand All @@ -564,7 +564,7 @@ class Editor extends React.Component {
{this.props.file.name}
<UnsavedChangesIndicator />
</span>
</header>
</>
<section>
<EditorHolder
ref={(element) => {
Expand Down
2 changes: 1 addition & 1 deletion client/modules/IDE/components/Header/Nav.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,7 @@ const UnauthenticatedUserMenu = () => {
</span>
</Link>
</li>
<span className="nav__item-or">{t('Nav.LoginOr')}</span>
<li className="nav__item-or">{t('Nav.LoginOr')}</li>
<li className="nav__item">
<Link to="/signup" className="nav__auth-button">
<span className="nav__item-header" title="SignUp">
Expand Down
4 changes: 2 additions & 2 deletions client/modules/IDE/components/Header/index.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,12 @@ const Header = (props) => {
const isMobile = useIsMobile();

return (
<header>
<>
<Nav />
{!isMobile && (
<Toolbar syncFileContent={props.syncFileContent} key={project.id} />
)}
</header>
</>
);
};

Expand Down