Skip to content

Fix edit rename using keyboard controls on SketchList && CollectionList #3150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Fix edit rename using keyboard controls on SketchList && CollectionList #3150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf225bf
Fix edit rename using keyboard controls on SketchList && CollectionList
PiyushChandra17 Jun 7, 2024
d0a49b9
Merge branch 'develop' into piyush/fix-edit-rename-using-keyboard
raclim Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion client/modules/IDE/components/CollectionList/CollectionListRow.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,6 +140,7 @@ const CollectionListRowBase = (props) => {

const handleRenameEnter = (e) => {
if (e.key === 'Enter') {
e.preventDefault();
updateName();
closeAll();
}
Expand Down Expand Up @@ -187,7 +188,7 @@ const CollectionListRowBase = (props) => {
<input
value={renameValue}
onChange={handleRenameChange}
onKeyUp={handleRenameEnter}
onKeyDown={handleRenameEnter}
onBlur={handleRenameBlur}
onClick={(e) => e.stopPropagation()}
ref={renameInput}
Expand Down
3 changes: 2 additions & 1 deletion client/modules/IDE/components/SketchList.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ class SketchListRowBase extends React.Component {

handleRenameEnter = (e) => {
if (e.key === 'Enter') {
e.preventDefault();
this.updateName();
this.closeRename();
}
Expand Down Expand Up @@ -173,7 +174,7 @@ class SketchListRowBase extends React.Component {
<input
value={renameValue}
onChange={this.handleRenameChange}
onKeyUp={this.handleRenameEnter}
onKeyDown={this.handleRenameEnter}
onBlur={this.handleRenameBlur}
onClick={(e) => e.stopPropagation()}
ref={this.renameInput}
Expand Down