Skip to content

Added more robust way to handle error #3152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Added more robust way to handle error #3152

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
427702a
Added more robust way to handle error
PiyushChandra17 Jun 8, 2024
72c0445
Merge branch 'develop' into piyush/Fix-deleteProject-promises-async-a…
raclim Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion server/controllers/project.controller/deleteProject.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,14 @@ export default async function deleteProject(req, res) {
res.status(error.code).json({ message: error.message });
};

function sendProjectNotFound() {
sendFailure(
new ProjectDeletionError('Project with that id does not exist', {
code: 404
})
);
}

try {
const project = await Project.findById(req.params.project_id);

Expand All @@ -60,6 +68,10 @@ export default async function deleteProject(req, res) {
await project.remove();
res.status(200).end();
} catch (error) {
sendFailure(error);
if (error.name === 'CastError' && error.kind === 'ObjectId') {
sendProjectNotFound();
} else {
sendFailure(error);
}
}
}