-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Changed color of sketch lines to theme color #3210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 Thanks for opening this pull request! Please check out our contributing guidelines if you haven't already. |
Hi @Noorain464 and welcome to the p5.js-web-editor repository! Could you please add details about the issue you're fixing? This will help us understand your changes better. |
I'm sorry, this is the issue I've solved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work on this! I'm a little concerned about inconsistencies with how links should appear in the editor, but I think this is an improvement from what it currently looks like, I feel like this is good for now!
A few other points to note:
- Although you included a screenshot, the image doesn't seem to reflect the specific changes. I added in a few images below of what it would ideally look like (i.e the changes in different themes). It would be great if you could add these types of details in future PRs!


- I removed some changes to the
previewServer.js
file, which I noticed is in another pull request you submitted. Ideally, we also would like to keep changes for issues separated in each pull request.
Thanks!
Fixes #issue-number
The color of sketch link in sketches table should be changed to theme color when hovered #2943
Changes:
I have verified that this pull request:
npm run lint
)npm run test
)develop
branch.Fixes #123